Issue 155900: When a web contents drag has a URL but no title, make up a title for it....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155900: When a web contents drag has a URL but no title, make up a title for it.... (Closed)

Created:
11 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

When a web contents drag has a URL but no title, make up a title for it. BUG=17393 TEST=drag nntp thumbnail to bookmark bar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21255

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	chrome/browser/tab_contents/tab_contents_view_gtk.cc	View		4 chunks	+16 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM http://codereview.chromium.org/155900/diff/1/2 File chrome/browser/tab_contents/tab_contents_view_gtk.cc (right): http://codereview.chromium.org/155900/diff/1/2#newcode796 Line 796: std::string name; Nit: If you add {} ...

11 years, 5 months ago (2009-07-22 00:51:07 UTC) #2

Evan Stade

11 years, 5 months ago (2009-07-22 00:54:55 UTC) #3

http://codereview.chromium.org/155900/diff/1/2
File chrome/browser/tab_contents/tab_contents_view_gtk.cc (right):

http://codereview.chromium.org/155900/diff/1/2#newcode796
Line 796: std::string name;
On 2009/07/22 00:51:08, tony wrote:
> Nit: If you add {} around the case block, you can declare this closer to where
> you use it.  *shrug*

oh, sweet. This has rather annoyed me.

Expand Messages | Collapse Messages