Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2615)

Unified Diff: net/url_request/url_request_job.h

Issue 155897: Add support to URLRequest for deferring redirects.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_job.h
===================================================================
--- net/url_request/url_request_job.h (revision 21335)
+++ net/url_request/url_request_job.h (working copy)
@@ -11,6 +11,7 @@
#include "base/ref_counted.h"
#include "base/scoped_ptr.h"
#include "base/time.h"
+#include "googleurl/src/gurl.h"
#include "net/base/filter.h"
#include "net/base/load_states.h"
@@ -22,7 +23,6 @@
class X509Certificate;
}
-class GURL;
class URLRequest;
class URLRequestStatus;
class URLRequestJobMetrics;
@@ -182,6 +182,8 @@
// Continue processing the request ignoring the last error.
virtual void ContinueDespiteLastError();
+ void FollowDeferredRedirect();
+
// Returns true if the Job is done producing response data and has called
// NotifyDone on the request.
bool is_done() const { return done_; }
@@ -303,11 +305,6 @@
// an error occurred (or we are waiting for IO to complete).
bool ReadRawDataForFilter(int *bytes_read);
- // Called in response to a redirect that was not canceled to follow the
- // redirect. The current job will be replaced with a new job loading the
- // given redirect destination.
- void FollowRedirect(const GURL& location, int http_status_code);
-
// Updates the profiling info and notifies observers that bytes_read bytes
// have been read.
void RecordBytesRead(int bytes_read);
@@ -319,6 +316,11 @@
// Record packet arrival times for possible use in histograms.
void UpdatePacketReadTimes();
+ // Called in response to a redirect that was not canceled to follow the
+ // redirect. The current job will be replaced with a new job loading the
+ // given redirect destination.
+ void FollowRedirect(const GURL& location, int http_status_code);
wtc 2009/07/23 00:30:12 Nit: move this method back to its original locatio
darin (slow to review) 2009/07/23 01:27:29 Done.
+
// Indicates that the job is done producing data, either it has completed
// all the data or an error has been encountered. Set exclusively by
// NotifyDone so that it is kept in sync with the request.
@@ -348,6 +350,10 @@
// Expected content size
int64 expected_content_size_;
+ // Set when a redirect is deferred.
+ GURL deferred_redirect_url_;
+ int deferred_redirect_status_code_;
+
//----------------------------------------------------------------------------
// Data used for statistics gathering in some instances. This data is only
// used for histograms etc., and is not required. It is optionally gathered

Powered by Google App Engine
This is Rietveld 408576698