Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 155889: Linux: use new xdg-settings "check" feature to determine whether we are the default browser. (Closed)

Created:
11 years, 5 months ago by Mike Mammarella
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang, Evan Stade
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Linux: use new xdg-settings "check" feature to determine whether we are the default browser. BUG=17093 TEST=in GNOME, let Firefox set itself as the default after Chrome has set itself; Chrome should then detect that it is no longer the default Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21260

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 2 1 chunk +18 lines, -17 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Mike Mammarella
11 years, 5 months ago (2009-07-22 00:23:39 UTC) #1
Evan Stade
http://codereview.chromium.org/155889/diff/1003/6 File chrome/browser/shell_integration_linux.cc (right): http://codereview.chromium.org/155889/diff/1003/6#newcode81 Line 81: // TODO: Really, being the default browser should ...
11 years, 5 months ago (2009-07-22 00:39:37 UTC) #2
Mike Mammarella
http://codereview.chromium.org/155889/diff/1003/6 File chrome/browser/shell_integration_linux.cc (right): http://codereview.chromium.org/155889/diff/1003/6#newcode81 Line 81: // TODO: Really, being the default browser should ...
11 years, 5 months ago (2009-07-22 01:34:31 UTC) #3
Evan Stade
11 years, 5 months ago (2009-07-22 01:36:33 UTC) #4
lgtm

http://codereview.chromium.org/155889/diff/10/1008
File chrome/browser/shell_integration_linux.cc (right):

http://codereview.chromium.org/155889/diff/10/1008#newcode86
Line 86: // Allow any reply that starts with "yes"
. at end of comment

Powered by Google App Engine
This is Rietveld 408576698