Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 155882: Make the tab close button color match the tab text.... (Closed)

Created:
11 years, 5 months ago by Glen Murphy
Modified:
9 years, 5 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Make the tab close button color match the tab text. BUG=17378 TEST=Install themes with different tab text colors and verify that the tab close button changes color appropriately. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/app/theme/tab_close.png View Binary file 0 comments Download
A chrome/app/theme/tab_close_mask.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/tabs/tab_renderer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/tabs/tab_renderer.cc View 4 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Glen Murphy
11 years, 5 months ago (2009-07-23 22:50:20 UTC) #1
jcampan
11 years, 5 months ago (2009-07-23 23:12:14 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698