Issue 155872: Fix for keys not working when plugin has focus in pingpong sample....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155872: Fix for keys not working when plugin has focus in pingpong sample.... (Closed)

Created:
11 years, 5 months ago by apatrick

Modified:
9 years, 7 months ago

Reviewers:
gman1

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Fix for keys not working when plugin has focus in pingpong sample. http://code.google.com/p/o3d/issues/detail?id=67 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21208

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -15 lines)			Patch
	M	samples/pingpong/o3dPingPong.html	View	1	1 chunk	+4 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gman

LGTM http://codereview.chromium.org/155872/diff/1/2 File samples/pingpong/o3dPingPong.html (right): http://codereview.chromium.org/155872/diff/1/2#newcode441 Line 441: o3djs.event.startKeyboardEventSynthesis(o3dElement); I thought this is called by ...

11 years, 5 months ago (2009-07-21 20:19:30 UTC) #2

apatrick

11 years, 5 months ago (2009-07-21 20:25:59 UTC) #3

http://codereview.chromium.org/155872/diff/1/2
File samples/pingpong/o3dPingPong.html (right):

http://codereview.chromium.org/155872/diff/1/2#newcode441
Line 441: o3djs.event.startKeyboardEventSynthesis(o3dElement);
On 2009/07/21 20:19:30, gman wrote:
> I thought this is called by makeClients? If so can you remove it here?

Done.

Expand Messages | Collapse Messages

Issue 155872: Fix for keys not working when plugin has focus in pingpong sample.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages