This change list improves IME support on Linux. Many corner cases that were n...

webkit/api/src/gtk/WebInputEventFactory.cpp

 /*
  * Copyright (C) 2006-2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 172 matching lines @@
     case GDK_KEY_RELEASE:
         result.type = WebInputEvent::KeyUp;
         break;
     case GDK_KEY_PRESS:
         result.type = WebInputEvent::RawKeyDown;
         break;
     default:
         ASSERT_NOT_REACHED();
     }
 
+    // According to MSDN:
+    // http://msdn.microsoft.com/en-us/library/ms646286(VS.85).aspx
+    // Key events with Alt modifier and F10 are system key events.
+    // We just emulate this behavior. It's necessary to prevent webkit from
+    // processing keypress event generated by alt-d, etc.
+    // F10 is not special on Linux, so don't treat it as system key.
+    if (result.modifiers & WebInputEvent::AltKey)
+        result.isSystemKey = true;
+
     // The key code tells us which physical key was pressed (for example, the
     // A key went down or up).  It does not determine whether A should be lower
     // or upper case.  This is what text does, which should be the keyval.
     result.windowsKeyCode = gdkEventToWindowsKeyCode(event);
     result.nativeKeyCode = event->hardware_keycode;
 
     switch (event->keyval) {
     // We need to treat the enter key as a key press of character \r.  This
     // is apparently just how webkit handles it and what it expects.
     case GDK_ISO_Enter:
     case GDK_KP_Enter:
     case GDK_Return:
         result.unmodifiedText[0] = result.text[0] = static_cast<WebUChar>('\r');
         break;
     default:
         // This should set text to 0 when it's not a real character.
         // FIXME: fix for non BMP chars
+        // TODO(james.su@gmail.com):
+        // Support control characters input like Windows.
+        // See: http://en.wikipedia.org/wiki/Control_characters
         result.unmodifiedText[0] = result.text[0] =
             static_cast<WebUChar>(gdk_keyval_to_unicode(event->keyval));
     }
 
     result.setKeyIdentifierFromWindowsKeyCode();
 
     // FIXME: Do we need to set IsAutoRepeat or IsKeyPad?
 
     return result;
 }
 
 WebKeyboardEvent WebInputEventFactory::keyboardEvent(wchar_t character, int state, double timeStampSeconds)
 {
     // keyboardEvent(const GdkEventKey*) depends on the GdkEventKey object and
     // it is hard to use/ it from signal handlers which don't use GdkEventKey
     // objects (e.g. GtkIMContext signal handlers.) For such handlers, this
     // function creates a WebInputEvent::Char event without using a
     // GdkEventKey object.
     WebKeyboardEvent result;
     result.type = WebKit::WebInputEvent::Char;
     result.timeStampSeconds = timeStampSeconds;
     result.modifiers = gdkStateToWebEventModifiers(state);
     result.windowsKeyCode = character;
     result.nativeKeyCode = character;
     result.text[0] = character;
     result.unmodifiedText[0] = character;
+
+    // According to MSDN:
+    // http://msdn.microsoft.com/en-us/library/ms646286(VS.85).aspx
+    // Key events with Alt modifier and F10 are system key events.
+    // We just emulate this behavior. It's necessary to prevent webkit from
+    // processing keypress event generated by alt-d, etc.
+    // F10 is not special on Linux, so don't treat it as system key.
+    if (result.modifiers & WebInputEvent::AltKey)
+        result.isSystemKey = true;
+
     return result;
 }
 
 // WebMouseEvent --------------------------------------------------------------
 
 WebMouseEvent WebInputEventFactory::mouseEvent(const GdkEventButton* event)
 {
     WebMouseEvent result;
 
     result.timeStampSeconds = gdkEventTimeToWebEventTime(event->time);
@@ skipping 115 matching lines @@
     case GDK_SCROLL_RIGHT:
         result.deltaX = -scrollbarPixelsPerTick;
         result.wheelTicksX = 1;
         break;
     }
 
     return result;
 }
 
 } // namespace WebKit