Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 155865: NNTP: Merge the recent activities into one list and show more items... (Closed)

Created:
11 years, 5 months ago by arv (Not doing code reviews)
Modified:
9 years, 4 months ago
Reviewers:
Glen Murphy
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

NNTP: Merge the recent activities into one list and show more items when the section is larger. Make the window menu look and behave more like a tooltip. Return more recently closed windows and tabs when using the NNTP. BUG=16539, 16835, 14963 TEST=Hide and show the tips section. More items (if there are more items) should be shown. Hover over a closed window and the tooltip should look like a tooltip on Vista/Win7 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21214

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 5

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -119 lines) Patch
M chrome/browser/dom_ui/new_tab_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/new_new_tab.css View 1 2 3 6 chunks +29 lines, -11 lines 0 comments Download
M chrome/browser/resources/new_new_tab.html View 1 2 3 4 3 chunks +32 lines, -59 lines 0 comments Download
M chrome/browser/resources/new_new_tab.js View 1 2 3 12 chunks +121 lines, -48 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
arv (Not doing code reviews)
11 years, 5 months ago (2009-07-21 19:26:56 UTC) #1
Glen Murphy
LGTM with minors: http://codereview.chromium.org/155865/diff/13/1014 File chrome/browser/dom_ui/new_tab_ui.cc (right): http://codereview.chromium.org/155865/diff/13/1014#newcode1221 Line 1221: const int max_count = NewTabUI::UseOldNewTabPage() ...
11 years, 5 months ago (2009-07-21 20:14:01 UTC) #2
arv (Not doing code reviews)
11 years, 5 months ago (2009-07-21 20:44:47 UTC) #3
http://codereview.chromium.org/155865/diff/13/1011
File chrome/browser/resources/new_new_tab.css (right):

http://codereview.chromium.org/155865/diff/13/1011#newcode444
Line 444: to(rgb(228,229,240)));
On 2009/07/21 20:14:01, Glen Murphy wrote:
> (Meta-question) How are we going to theme all these hardcoded colors sanely?

These ones should be covered by the CSS appearance.

The rest should just have a master color and we should calculate the other
colors from it by making things brighter and darker. Gmail did this pretty
efficiently. The theme provided 4 or so basic colors and the rest where
calculated based on that.

http://codesearch/p#google3/java/com/google/caribou/ui/pinto/gss/leaves/leave...

I think one thing we could do is to use some CSS template language that allows
us to use named constants for the colors.

http://codereview.chromium.org/155865/diff/13/1012
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/155865/diff/13/1012#newcode244
Line 244: .style.backgroundImage:'url(chrome://theme/downloads_favicon)';
On 2009/07/21 20:14:01, Glen Murphy wrote:
> 80col? (can't tell)

Done.

Powered by Google App Engine
This is Rietveld 408576698