Issue 155860: GTK: Popup notification is readable with dark themes in chrome theme mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155860: GTK: Popup notification is readable with dark themes in chrome theme mode. (Closed)

Created:
11 years, 5 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

GTK: Popup notification is readable with dark themes in chrome theme mode. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21206

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -2 lines)			Patch
	M	chrome/browser/gtk/blocked_popup_container_view_gtk.h	View		4 chunks	+11 lines, -0 lines	0 comments	Download
	M	chrome/browser/gtk/blocked_popup_container_view_gtk.cc	View		4 chunks	+41 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

11 years, 5 months ago (2009-07-21 20:00:41 UTC) #2

cool, lgtm w/nit

http://codereview.chromium.org/155860/diff/1/2
File chrome/browser/gtk/blocked_popup_container_view_gtk.cc (right):

http://codereview.chromium.org/155860/diff/1/2#newcode105
Line 105: if (type == NotificationType::BROWSER_THEME_CHANGED) {
in the interest of keeping things as little indented as possible I think I'd
just make this a DCHECK

Expand Messages | Collapse Messages