Issue 155849: Make stub cache hash work on X64 platform. Stub cache now works....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155849: Make stub cache hash work on X64 platform. Stub cache now works.... (Closed)

Created:
11 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make stub cache hash work on X64 platform. Stub cache now works. Switch arguments of 32-bit arithmetic instructions so they are consistent with 64-bit arithmetic instructions (all on X64 platforms). Committed: http://code.google.com/p/v8/source/detail?r=2516

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -17 lines)			Patch
M	src/stub-cache.h	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/x64/assembler-x64.h	View		4 chunks	+12 lines, -9 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		2 chunks	+67 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 5 months ago (2009-07-21 13:24:39 UTC) #2

STV!

http://codereview.chromium.org/155849/diff/1/5
File src/stub-cache.h (right):

http://codereview.chromium.org/155849/diff/1/5#newcode262
Line 262: // This makes it a lot easier to avoid
nit: could you put more on this line and less on the next?

Expand Messages | Collapse Messages