Add unit test for chrome\installer\util\version

Add unit test for chrome\installer\util\version

BUG=none
TEST=this


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21229

[sra, 2009-07-21 05:43:30]

Hi Rahul,

I wrote this test some while ago when I was trying to figure out if some path
through the installer was infeasbile.  We might as well keep the test.

[kuchhal, 2009-07-21 16:09:22]

lgtm, thanks for adding this.

some nits below.

http://codereview.chromium.org/155842/diff/4/6
File chrome/installer/util/version_unittest.cc (right):

http://codereview.chromium.org/155842/diff/4/6#newcode12
Line 12: static const installer::Version* no_version = NULL;
rename to kNoVersion?

http://codereview.chromium.org/155842/diff/4/6#newcode14
Line 14: TEST(VersionTests, Parse) {
I think the convention is to name the class as VersionTest not VersionTests

http://codereview.chromium.org/155842/diff/4/6#newcode24
Line 24: delete v1;
use a scoped_ptr instead?

[sra, 2009-07-21 23:19:19]

I'll submit when the tree opens.

http://codereview.chromium.org/155842/diff/4/6
File chrome/installer/util/version_unittest.cc (right):

http://codereview.chromium.org/155842/diff/4/6#newcode12
Line 12: static const installer::Version* no_version = NULL;
On 2009/07/21 16:09:22, kuchhal wrote:
> rename to kNoVersion?

Done.

http://codereview.chromium.org/155842/diff/4/6#newcode14
Line 14: TEST(VersionTests, Parse) {
On 2009/07/21 16:09:22, kuchhal wrote:
> I think the convention is to name the class as VersionTest not VersionTests

Done.

http://codereview.chromium.org/155842/diff/4/6#newcode24
Line 24: delete v1;
On 2009/07/21 16:09:22, kuchhal wrote:
> use a scoped_ptr instead?

Done.