Issue 155834: fix warnings treated as errors on line 94 and 97 that are allowed on try serv...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155834: fix warnings treated as errors on line 94 and 97 that are allowed on try serv... (Closed)

Created:
11 years, 5 months ago by fbarchard

Modified:
9 years, 7 months ago

Reviewers:
hclam.chromium

CC:
chromium-reviews_googlegroups.com, scherkus (not reviewing), fbarchard, awong, kylep

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

fix warnings treated as errors on line 94 and 97 that are allowed on try server, but not buildbot. doh BUG=17304 TEST=buildbot has different warnings than try server. this patch reenables the qtfaststart build with 2 warnings fixed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21215

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 2

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	media/media.gyp	View	1 2 3 4 5	1 chunk	+7 lines, -0 lines	0 comments	Download
	M	media/tools/qt-faststart.c	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fbarchard

can you do a quick review of this warning fix? this is to fix the ...

11 years, 5 months ago (2009-07-21 18:36:36 UTC) #1

Alpha Left Google

LGTM. http://codereview.chromium.org/155834/diff/10/11 File media/tools/qt-faststart.c (right): http://codereview.chromium.org/155834/diff/10/11#newcode94 Line 94: uint64_t last_offset = 0; // warning: 'last_offset' ...

11 years, 5 months ago (2009-07-21 18:39:17 UTC) #2

fbarchard

11 years, 5 months ago (2009-07-21 20:47:39 UTC) #3

i'm experiencing gcl commit issues.
as a work around, i'll delete the file (alpha will have to do it), and resubmit
the file as qt_faststart.c

http://codereview.chromium.org/155834/diff/10/11
File media/tools/qt-faststart.c (right):

http://codereview.chromium.org/155834/diff/10/11#newcode94
Line 94: uint64_t last_offset = 0;  // warning: 'last_offset' may be used
uninitialized in this function
I'm going to need to justify these 2 lines to get the change back into ffmpeg
mainline, as they were previously questioned.
So I'll remove the comment in the next upload, once their purpose has passed.

Expand Messages | Collapse Messages