Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 155820: Coverity fixes to keep coverity quiet.... (Closed)

Created:
11 years, 5 months ago by sra
Modified:
9 years, 7 months ago
Reviewers:
Finnur, Peter Kasting
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Coverity fixes to keep coverity quiet. Only the first issue is remotely interesting. * Possibility (low) of using NULL SinkStream* courgette tool 'gen1a' command. * Added initializers for all class members to several constructors. * return 0 at end of from wmain. BUG=none TEST=existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21253

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
MM courgette/adjustment_method.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download
M courgette/adjustment_method_2.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M courgette/courgette_minimal_tool.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M courgette/courgette_tool.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M courgette/encoded_program.cc View 1 1 chunk +1 line, -1 line 0 comments Download
MM courgette/image_info.cc View 1 1 chunk +20 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sra
11 years, 5 months ago (2009-07-21 00:09:50 UTC) #1
Peter Kasting
http://codereview.chromium.org/155820/diff/1/7 File courgette/image_info.cc (right): http://codereview.chromium.org/155820/diff/1/7#newcode29 Line 29: start_(0), end_(0), length_(0), Drive-by: should probably move end_ ...
11 years, 5 months ago (2009-07-21 01:20:27 UTC) #2
sra
http://codereview.chromium.org/155820/diff/1/7 File courgette/image_info.cc (right): http://codereview.chromium.org/155820/diff/1/7#newcode29 Line 29: start_(0), end_(0), length_(0), On 2009/07/21 01:20:27, pkasting wrote: ...
11 years, 5 months ago (2009-07-21 03:05:40 UTC) #3
Finnur
11 years, 5 months ago (2009-07-21 22:54:35 UTC) #4
Sorry; got delayed in reviewing this.

LGTM.

On 2009/07/21 03:05:40, sra wrote:
> http://codereview.chromium.org/155820/diff/1/7
> File courgette/image_info.cc (right):
> 
> http://codereview.chromium.org/155820/diff/1/7#newcode29
> Line 29: start_(0), end_(0), length_(0),
> On 2009/07/21 01:20:27, pkasting wrote:
> > Drive-by: should probably move end_ and length_ onto their own lines too
> 
> Done.

Powered by Google App Engine
This is Rietveld 408576698