Issue 155816: [Mac] Prevent the field from updating the font panel and any ruler state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155816: [Mac] Prevent the field from updating the font panel and any ruler state. (Closed)

Created:
11 years, 5 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] Prevent the field from updating the font panel and any ruler state.

Patch Set 1 #

Patch Set 2 : Update comments around -setUsesFontPanel: research. #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/autocomplete_text_field_editor.mm	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

The other day nirnamesh sent me a valgrind report (*) which was deep in some ...

11 years, 5 months ago (2009-07-20 23:07:33 UTC) #1

John Grabowski

LGTM Might be good to know why setUsesFontPanel: gets unset, but this change seems fine ...

11 years, 5 months ago (2009-07-20 23:45:15 UTC) #2

Scott Hess - ex-Googler

11 years, 5 months ago (2009-07-21 17:40:31 UTC) #3

On 2009/07/20 23:45:15, John Grabowski wrote:
> LGTM
> 
> Might be good to know why setUsesFontPanel: gets unset, but this change seems
> fine independent of that.

I dropped in an intercept for -setUsesFontPanel:, and it gets called ALL THE
TIME with YES.  The calls we're doing which lead to it are such obvious things
as NSTextField -stringValue.  Neat!

I'll upgrade the comment to describe this a bit.

Expand Messages | Collapse Messages