Issue 1558030: Canonicalize URL before using Extractscheme in DoFindAndCompareScheme functio...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1558030: Canonicalize URL before using Extractscheme in DoFindAndCompareScheme functio... (Closed)

Created:
10 years, 8 months ago by inferno

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
http://google-url.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Canonicalize URL before using Extractscheme in DoFindAndCompareScheme function. BUG=40445 TEST=URLUtilTest.FindAndCompareScheme

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	src/url_util.cc	View		2 chunks	+9 lines, -2 lines	0 comments	Download
	M	src/url_util_unittest.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

inferno

Brett, please review this code change. I matched the exact canonicalization in docanonicalize() function which ...

10 years, 8 months ago (2010-04-08 05:31:51 UTC) #1

brettw

10 years, 8 months ago (2010-04-08 17:09:12 UTC) #2

I checked this into googleurl@129

I renamed the ctrlStr variables to use google_style_variable_names. I thought
about some other cases this could be wrong with respect to control chars, which
is a bit subtle. The code seems correct, but I added some additional comments
and an extra test to prevent future regressions. You can see the patch here:

http://code.google.com/p/google-url/source/detail?r=129

Expand Messages | Collapse Messages