Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1558003: linux: enable seccomp sandbox by default (Closed)

Created:
10 years, 8 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

linux: enable seccomp sandbox by default It seems the best way to keep the seccomp sandbox working is to have everyone's development environment have it on by default. So we turn on the seccomp sandbox, but only for non-official builds. If the build-time flag is set: --disable-seccomp-sandbox turns it off. If the build-time flag is *not* set: --enable-seccomp-sandbox turns it on. BUG=36133 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43122

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : nacl unit test #

Patch Set 4 : better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -17 lines) Patch
M build/common.gypi View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/zygote_host_linux.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/zygote_main_linux.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 chunks +22 lines, -3 lines 0 comments Download
M chrome/renderer/renderer_main_platform_delegate_linux.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/nacl/nacl_test.cc View 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
10 years, 8 months ago (2010-03-29 20:53:46 UTC) #1
Markus (顧孟勤)
LGTM Seeking shelter under my desk now
10 years, 8 months ago (2010-03-29 21:00:52 UTC) #2
Evan Martin
10 years, 8 months ago (2010-03-30 17:51:42 UTC) #3
+NaCL master, please take a look at my NaCL change.

Powered by Google App Engine
This is Rietveld 408576698