Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 155771: X64: Add instructions to disassembler. Skip hanging test-api test. (Closed)

Created:
11 years, 5 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

X64: Add instructions to disassembler. Skip hanging test-api test. Committed: http://code.google.com/p/v8/source/detail?r=2513

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -149 lines) Patch
M src/x64/disasm-x64.cc View 1 2 10 chunks +145 lines, -149 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
To make two-byte opcodes work with REX prefixes, they needed to be cleaned up. They ...
11 years, 5 months ago (2009-07-20 14:32:46 UTC) #1
Mads Ager (chromium)
LGTM! http://codereview.chromium.org/155771/diff/1/3 File src/x64/disasm-x64.cc (right): http://codereview.chromium.org/155771/diff/1/3#newcode943 Line 943: // These instructions may be affected an ...
11 years, 5 months ago (2009-07-20 14:48:05 UTC) #2
William Hesse
11 years, 5 months ago (2009-07-20 14:58:02 UTC) #3
http://codereview.chromium.org/155771/diff/1/3
File src/x64/disasm-x64.cc (right):

http://codereview.chromium.org/155771/diff/1/3#newcode943
Line 943: // These instructions may be affected an 0x66, 0xF2, or 0xF3 prefix,
On 2009/07/20 14:48:06, Mads Ager wrote:
> Terminate with period instead of comma.
> 
> affected -> affected by?

Done.

http://codereview.chromium.org/155771/diff/1/3#newcode947
Line 947: byte *current = data + 2;
On 2009/07/20 14:48:06, Mads Ager wrote:
> byte * -> byte*

Done.

Powered by Google App Engine
This is Rietveld 408576698