Issue 155727: Fix a crash in plugin handling. The code was destroying the passed-in cairo_t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155727: Fix a crash in plugin handling. The code was destroying the passed-in cairo_t... (Closed)

Created:
11 years, 5 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash in plugin handling. The code was destroying the passed-in cairo_t, which I broke when I changed the argument to cairo_t from a raw surface, and removed the extra surface creation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21020

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	webkit/glue/plugins/webplugin_delegate_impl_gtk.cc	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 5 months ago (2009-07-18 00:51:41 UTC) #2

LGTM

http://codereview.chromium.org/155727/diff/1/2
File webkit/glue/plugins/webplugin_delegate_impl_gtk.cc (left):

http://codereview.chromium.org/155727/diff/1/2#oldcode560
Line 560: cairo_destroy(context);
i apologize for this code, it makes absolutely no sense now that i look at it
harder

Expand Messages | Collapse Messages