Issue 155716: o3djs.utils.makeClients checks that Renderer has been initialized....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155716: o3djs.utils.makeClients checks that Renderer has been initialized.... (Closed)

Created:
11 years, 5 months ago by apatrick

Modified:
9 years, 7 months ago

Reviewers:
gman1

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

o3djs.utils.makeClients checks that Renderer has been initialized. Prevents case where init callback is called before NPP_SetWindow (which initializes the renderer). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21188

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	samples/o3djs/util.js	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gman

LGTM except one minor thing http://codereview.chromium.org/155716/diff/1/2 File samples/o3djs/util.js (right): http://codereview.chromium.org/155716/diff/1/2#newcode858 Line 858: o3djs.util.rendererInitStatus.UNINITIALIZED; I think ...

11 years, 5 months ago (2009-07-18 02:12:52 UTC) #2

apatrick

11 years, 5 months ago (2009-07-20 19:56:48 UTC) #3

http://codereview.chromium.org/155716/diff/1/2
File samples/o3djs/util.js (right):

http://codereview.chromium.org/155716/diff/1/2#newcode858
Line 858: o3djs.util.rendererInitStatus.UNINITIALIZED;
On 2009/07/18 02:12:52, gman wrote:
> I think you want to check that element.client exists before checking for
> element.client.rendererInitStatus?
> 
> 

Done.

Expand Messages | Collapse Messages