Issue 155711: Renamed FilterHost::Error() and Pipeline::GetTime() to more appropriate names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155711: Renamed FilterHost::Error() and Pipeline::GetTime() to more appropriate names. (Closed)

Created:
11 years, 5 months ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Renamed FilterHost::Error() and Pipeline::GetTime() to more appropriate names. BUG=17107 TEST=none

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -59 lines)			Patch
M	chrome/renderer/media/audio_renderer_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/media/buffered_data_source.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	media/base/filter_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/filter_host_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/filter_host_impl.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	media/base/mock_filter_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/mock_filters.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	media/base/pipeline.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	media/base/pipeline_impl.h	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	media/base/pipeline_impl.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	media/base/pipeline_impl_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/filters/audio_renderer_base.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/filters/audio_renderer_base_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/decoder_base.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/ffmpeg_audio_decoder.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer_unittest.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	media/filters/ffmpeg_video_decoder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/ffmpeg_video_decoder_unittest.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	media/filters/file_data_source.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/video_renderer_base.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	media/filters/video_renderer_base_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	media/player/movie.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/media/simple_data_source.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/webmediaplayer_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages