Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3867)

Unified Diff: chrome/renderer/resources/extension_process_bindings.js

Issue 155707: Changed the extension.connect() API not to broadcast to all tabs. Added a (Closed)
Patch Set: review comments Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/renderer_resources.grd ('k') | chrome/test/testing_profile.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extension_process_bindings.js
diff --git a/chrome/renderer/resources/extension_process_bindings.js b/chrome/renderer/resources/extension_process_bindings.js
index b9a0548aa27c5c91a916c546edaeec71688085f5..e702744e6e0cb27737721929f2dc7fbb038d0187 100644
--- a/chrome/renderer/resources/extension_process_bindings.js
+++ b/chrome/renderer/resources/extension_process_bindings.js
@@ -17,6 +17,7 @@ var chrome = chrome || {};
native function GetViews();
native function GetChromeHidden();
native function GetNextRequestId();
+ native function OpenChannelToTab();
if (!chrome)
chrome = {};
@@ -304,6 +305,17 @@ var chrome = chrome || {};
chrome.types.optFun
];
+ chrome.tabs.connect = function(tabId, opt_name) {
+ validate(arguments, arguments.callee.params);
+ var portId = OpenChannelToTab(tabId, chrome.extension.id_, opt_name || "");
+ return chromeHidden.Port.createPort(portId, opt_name);
+ };
+
+ chrome.tabs.connect.params = [
+ chrome.types.pInt,
+ chrome.types.optStr
+ ];
+
// Sends ({Tab}).
// Will *NOT* be followed by tab-attached - it is implied.
// *MAY* be followed by tab-selection-changed.
@@ -531,7 +543,7 @@ var chrome = chrome || {};
chrome.extension = new chrome.Extension(extensionId);
// TODO(mpcomplete): self.onConnect is deprecated. Remove it at 1.0.
// http://code.google.com/p/chromium/issues/detail?id=16356
- chrome.self.onConnect = new chrome.Event("channel-connect:" + extensionId);
+ chrome.self.onConnect = chrome.extension.onConnect;
setupPageActionEvents(extensionId);
});
« no previous file with comments | « chrome/renderer/renderer_resources.grd ('k') | chrome/test/testing_profile.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698