Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7582)

Unified Diff: chrome/common/render_messages_internal.h

Issue 155707: Changed the extension.connect() API not to broadcast to all tabs. Added a (Closed)
Patch Set: review comments Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/render_messages_internal.h
diff --git a/chrome/common/render_messages_internal.h b/chrome/common/render_messages_internal.h
index 71675fe317c1412ee168479a5627a5de625c870b..301bf34b43d33d63a1840c70a10e870088750d52 100644
--- a/chrome/common/render_messages_internal.h
+++ b/chrome/common/render_messages_internal.h
@@ -552,11 +552,14 @@ IPC_BEGIN_MESSAGES(View)
std::string /* response */,
std::string /* error */)
- // Call a javascript function in every registered context in this process.
+ // This message is optionally routed. If used as a control message, it
+ // will call a javascript function in every registered context in the
+ // target process. If routed, it will be restricted to the contexts that
+ // are part of the target RenderView.
// |args| is a list of primitive Value types that are passed to the function.
- IPC_MESSAGE_CONTROL2(ViewMsg_ExtensionMessageInvoke,
- std::string /* function_name */,
- ListValue /* args */)
+ IPC_MESSAGE_ROUTED2(ViewMsg_ExtensionMessageInvoke,
+ std::string /* function_name */,
+ ListValue /* args */)
// Tell the renderer process all known extension function names.
IPC_MESSAGE_CONTROL1(ViewMsg_Extension_SetFunctionNames,
@@ -1428,11 +1431,13 @@ IPC_BEGIN_MESSAGES(ViewHost)
std::string /* channel_name */,
int /* port_id */)
- // Get a port handle to the given tab's process. The handle can be used for
- // sending messages to the extension.
- IPC_SYNC_MESSAGE_CONTROL2_1(ViewHostMsg_OpenChannelToTab,
+ // Get a port handle to the given tab. The handle can be used for sending
+ // messages to the extension.
+ IPC_SYNC_MESSAGE_CONTROL4_1(ViewHostMsg_OpenChannelToTab,
int /* routing_id */,
int /* tab_id */,
+ std::string /* extension_id */,
+ std::string /* channel_name */,
int /* port_id */)
// Send a message to an extension process. The handle is the value returned
« no previous file with comments | « chrome/browser/renderer_host/resource_message_filter.cc ('k') | chrome/renderer/extensions/bindings_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698