Issue 155704: Remove calls to deprecated APIs so that Chromium compiles on all currently-fu...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155704: Remove calls to deprecated APIs so that Chromium compiles on all currently-fu... (Closed)

Created:
11 years, 5 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove calls to deprecated APIs so that Chromium compiles on all currently-future versions of OS X. BUG=none TEST=compile on a future version of OS X. Should build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20984

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -2 lines)			Patch
	M	third_party/mozilla/include/NSURL+Utils.m	View		2 chunks	+15 lines, -2 lines	2 comments	Download
	M	third_party/mozilla/include/README.chromium	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

LGTM with 1 issue http://codereview.chromium.org/155704/diff/1/3 File third_party/mozilla/include/NSURL+Utils.m (right): http://codereview.chromium.org/155704/diff/1/3#newcode121 Line 121: encoding:NSWindowsCP1252StringEncoding // best guess ...

11 years, 5 months ago (2009-07-17 19:36:57 UTC) #2

Avi (use Gerrit)

11 years, 5 months ago (2009-07-17 19:52:18 UTC) #3

http://codereview.chromium.org/155704/diff/1/3
File third_party/mozilla/include/NSURL+Utils.m (right):

http://codereview.chromium.org/155704/diff/1/3#newcode121
Line 121: encoding:NSWindowsCP1252StringEncoding  // best guess here
On 2009/07/17 19:36:57, pink wrote:
> IE here is Mac IE 5, not winIE. The encoding is probably something mac-like.

Really, though? Mac IE 5 hasn't been around since 1994, five years. The user's
much more likely to get a .url file from Windows than Mac IE 5 (I've personally
seen this...).

Expand Messages | Collapse Messages