Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 155687: Make Array::kHeaderSize protected, and only use kHeaderSize of its subclasses... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/ic-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2879 matching lines...) Expand 10 before | Expand all | Expand 10 after
2890 // The property must be set by generated code. 2890 // The property must be set by generated code.
2891 LoadAndSpill(value); 2891 LoadAndSpill(value);
2892 frame_->EmitPop(r0); 2892 frame_->EmitPop(r0);
2893 2893
2894 // Fetch the object literal. 2894 // Fetch the object literal.
2895 __ ldr(r1, frame_->Top()); 2895 __ ldr(r1, frame_->Top());
2896 // Get the elements array. 2896 // Get the elements array.
2897 __ ldr(r1, FieldMemOperand(r1, JSObject::kElementsOffset)); 2897 __ ldr(r1, FieldMemOperand(r1, JSObject::kElementsOffset));
2898 2898
2899 // Write to the indexed properties array. 2899 // Write to the indexed properties array.
2900 int offset = i * kPointerSize + Array::kHeaderSize; 2900 int offset = i * kPointerSize + FixedArray::kHeaderSize;
2901 __ str(r0, FieldMemOperand(r1, offset)); 2901 __ str(r0, FieldMemOperand(r1, offset));
2902 2902
2903 // Update the write barrier for the array address. 2903 // Update the write barrier for the array address.
2904 __ mov(r3, Operand(offset)); 2904 __ mov(r3, Operand(offset));
2905 __ RecordWrite(r1, r3, r2); 2905 __ RecordWrite(r1, r3, r2);
2906 } 2906 }
2907 ASSERT(frame_->height() == original_height + 1); 2907 ASSERT(frame_->height() == original_height + 1);
2908 } 2908 }
2909 2909
2910 2910
(...skipping 3491 matching lines...) Expand 10 before | Expand all | Expand 10 after
6402 int CompareStub::MinorKey() { 6402 int CompareStub::MinorKey() {
6403 // Encode the two parameters in a unique 16 bit value. 6403 // Encode the two parameters in a unique 16 bit value.
6404 ASSERT(static_cast<unsigned>(cc_) >> 28 < (1 << 15)); 6404 ASSERT(static_cast<unsigned>(cc_) >> 28 < (1 << 15));
6405 return (static_cast<unsigned>(cc_) >> 27) | (strict_ ? 1 : 0); 6405 return (static_cast<unsigned>(cc_) >> 27) | (strict_ ? 1 : 0);
6406 } 6406 }
6407 6407
6408 6408
6409 #undef __ 6409 #undef __
6410 6410
6411 } } // namespace v8::internal 6411 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/ic-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698