Make sure we don't crash if NewProxy returns an empty handle (only...

src/api.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2462 matching lines @@
     return pointer;
   }
 
   // Read from uninitialized field.
   if (!pointer->IsProxy()) {
     // Play safe even if it's something unexpected.
     ASSERT(pointer->IsUndefined());
     return NULL;
   }
 
-  // Unaligned native pointer
+  // Unaligned native pointer.
   return reinterpret_cast<void*>(i::Proxy::cast(pointer)->proxy());
 }
 
 
 void v8::Object::SetPointerInInternalField(int index, void* value) {
   i::Handle<i::JSObject> obj = Utils::OpenHandle(this);
   i::Object* as_object = reinterpret_cast<i::Object*>(value);
   if (as_object->IsSmi()) {
     // Aligned pointer, store as is.
     obj->SetInternalField(index, as_object);
   } else {
-    // Currently internal fields are used by DOM wrappers which
-    // only get GCed by the mark-sweep collector,
-    // so let's put proxy into old space.
-    i::Proxy* proxy = *i::Factory::NewProxy(reinterpret_cast<i::Address>(value),
-                                            i::TENURED);
-    obj->SetInternalField(index, proxy);
+    // Currently internal fields are used by DOM wrappers which only
+    // get garbage collected by the mark-sweep collector, so we
+    // pretenure the proxy.
+    i::Handle<i::Proxy> proxy =
+        i::Factory::NewProxy(reinterpret_cast<i::Address>(value), i::TENURED);
+    if (!proxy.is_null()) obj->SetInternalField(index, *proxy);
   }
 }
 
 
 // --- E n v i r o n m e n t ---
 
 bool v8::V8::Initialize() {
   if (i::V8::IsRunning()) return true;
   ENTER_V8;
   HandleScope scope;
@@ skipping 1052 matching lines @@
       reinterpret_cast<HandleScopeImplementer*>(storage);
   List<void**>* blocks_of_archived_thread = thread_local->Blocks();
   v8::ImplementationUtilities::HandleScopeData* handle_data_of_archived_thread =
       &thread_local->handle_scope_data_;
   Iterate(v, blocks_of_archived_thread, handle_data_of_archived_thread);
 
   return storage + ArchiveSpacePerThread();
 }
 
 } }  // namespace v8::internal