Do not block all task manager tree view mouse release events....

Do not block all task manager tree view mouse release events.

BUG=16974
TEST=you can resize rows of the task manager


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21006

[Evan Stade, 2009-07-17 18:10:18]

On 2009/07/17 01:30:38, Evan Stade wrote:
> 
ping

[James Hawkins, 2009-07-17 18:15:42]

On 2009/07/17 18:10:18, Evan Stade wrote:
> On 2009/07/17 01:30:38, Evan Stade wrote:
> > 
> ping

Nack, the context menu shouldn't open in the treeview.  I'll send you a CL
shortly.

[Evan Stade, 2009-07-17 18:22:23]

updated. take another look?

[James Hawkins, 2009-07-17 18:58:52]

On 2009/07/17 18:22:23, Evan Stade wrote:
> updated. take another look?

nack, checking for mouse position in bounds is overkill when we can just check
the treeview widget.

[Evan Stade, 2009-07-17 19:01:35]

On 2009/07/17 18:58:52, James Hawkins wrote:
> On 2009/07/17 18:22:23, Evan Stade wrote:
> > updated. take another look?
> 
> nack, checking for mouse position in bounds is overkill when we can just check
> the treeview widget.

I highly doubt that call is more computationally intensive than installing and
calling an extra handler, besides we already have to make this check anyway.
There are copious places in the code where we do this already.

[Elliot Glaysher, 2009-07-17 19:08:30]

I am voting for this implementation. LGTM.

On 2009/07/17 19:01:35, Evan Stade wrote:
> On 2009/07/17 18:58:52, James Hawkins wrote:
> > On 2009/07/17 18:22:23, Evan Stade wrote:
> > > updated. take another look?
> > 
> > nack, checking for mouse position in bounds is overkill when we can just
check
> > the treeview widget.
> 
> I highly doubt that call is more computationally intensive than installing and
> calling an extra handler, besides we already have to make this check anyway.
> There are copious places in the code where we do this already.

[James Hawkins, 2009-07-17 19:09:21]

On 2009/07/17 19:08:30, Elliot Glaysher wrote:
> I am voting for this implementation. LGTM.
> 
> On 2009/07/17 19:01:35, Evan Stade wrote:
> > On 2009/07/17 18:58:52, James Hawkins wrote:
> > > On 2009/07/17 18:22:23, Evan Stade wrote:
> > > > updated. take another look?
> > > 
> > > nack, checking for mouse position in bounds is overkill when we can just
> check
> > > the treeview widget.
> > 
> > I highly doubt that call is more computationally intensive than installing
and
> > calling an extra handler, besides we already have to make this check anyway.
> > There are copious places in the code where we do this already.

Please add the comment back in, then lg.