Issue 155668: Refactoring of tabbed-pane component so it can be ported to Linux toolkit_view

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155668: Refactoring of tabbed-pane component so it can be ported to Linux toolkit_view (Closed)

Created:
11 years, 5 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Refactoring of tabbed-pane component so it can be ported to Linux toolkit_view. BUG=None TEST=Make sure the Options dialog still works as expected (tab selection, focus traversal...) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21189

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

	Unified diffs	Side-by-side diffs	Stats (+531 lines, -619 lines)
M	chrome/browser/views/options/content_page_view.cc	View	1 chunk	+1 line, -0 lines	0 comments
M	chrome/browser/views/options/fonts_languages_window_view.h	View	2 chunks	+5 lines, -3 lines	0 comments
M	chrome/browser/views/options/fonts_languages_window_view.cc	View	1 chunk	+1 line, -0 lines	0 comments
M	chrome/browser/views/options/languages_page_view.cc	View	1 chunk	+1 line, -1 line	0 comments
M	chrome/browser/views/options/options_window_view.cc	View	2 chunks	+2 lines, -4 lines	0 comments
MM	chrome/browser/views/options/passwords_exceptions_window_view.h	View	1 chunk	+4 lines, -2 lines	0 comments
M	chrome/browser/views/options/passwords_exceptions_window_view.cc	View	1 chunk	+1 line, -0 lines	0 comments
D	views/controls/tabbed_pane.h	View	1 chunk	+0 lines, -94 lines	0 comments
D	views/controls/tabbed_pane.cc	View	1 chunk	+0 lines, -264 lines	0 comments
A	views/controls/tabbed_pane/native_tabbed_pane_win.h	View	1 chunk	+69 lines, -0 lines	0 comments
A	views/controls/tabbed_pane/native_tabbed_pane_win.cc	View	1 chunk	+300 lines, -0 lines	0 comments
A	views/controls/tabbed_pane/native_tabbed_pane_wrapper.h	View	1 chunk	+68 lines, -0 lines	0 comments
A +	views/controls/tabbed_pane/tabbed_pane.h	View	3 chunks	+29 lines, -31 lines	0 comments
A +	views/controls/tabbed_pane/tabbed_pane.cc	View	2 chunks	+38 lines, -213 lines	0 comments
M	views/focus/focus_manager_unittest.cc	View	4 chunks	+7 lines, -5 lines	0 comments
M	views/views.gyp	View	1 chunk	+5 lines, -2 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages