Issue 155653: Include output of "lsb_release -d" in crash reports....

Issue 155653: Include output of "lsb_release -d" in crash reports.... (Closed)

Created:
11 years, 5 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Include output of "lsb_release -d" in crash reports. /etc/lsb-release does not exist on all distros, and sometimes it does not provide any useful info. Whereas all LSB complaint distros return useful data with the lsb_release command. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20936

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 3

Patch Set 4 : '' #

Total comments: 7

Patch Set 5 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -68 lines)			Patch
M	base/linux_util.h	View	1 2 3 4	2 chunks	+6 lines, -0 lines	0 comments	Download
M	base/linux_util.cc	View	1 2 3 4	2 chunks	+32 lines, -1 line	0 comments	Download
M	chrome/app/breakpad_linux.h	View	1 2 3 4	1 chunk	+14 lines, -7 lines	0 comments	Download
M	chrome/app/breakpad_linux.cc	View	1 2 3 4	15 chunks	+83 lines, -23 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.h	View	3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1 2 3 4	9 chunks	+21 lines, -29 lines	0 comments	Download
M	chrome/browser/renderer_host/render_crash_handler_host_linux.cc	View	1 2 3 4	5 chunks	+19 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://codereview.chromium.org/155653/diff/1011/1018 File chrome/browser/renderer_host/browser_render_process_host.cc (left): http://codereview.chromium.org/155653/diff/1011/1018#oldcode38 Line 38: #include "chrome/browser/renderer_host/render_view_host.h" on line 64 below. http://codereview.chromium.org/155653/diff/1011/1017 File ...

11 years, 5 months ago (2009-07-16 21:58:43 UTC) #1

Lei Zhang

11 years, 5 months ago (2009-07-17 00:19:12 UTC) #2

agl

LGTM http://codereview.chromium.org/155653/diff/1021/1023 File base/linux_util.cc (right): http://codereview.chromium.org/155653/diff/1021/1023#newcode36 Line 36: std::string linux_distro = "Unknown"; Probably should add ...

11 years, 5 months ago (2009-07-17 01:33:35 UTC) #3

Lei Zhang

11 years, 5 months ago (2009-07-17 05:53:57 UTC) #4

http://codereview.chromium.org/155653/diff/1021/1023
File base/linux_util.cc (right):

http://codereview.chromium.org/155653/diff/1021/1023#newcode36
Line 36: std::string linux_distro = "Unknown";
On 2009/07/17 01:33:36, agl wrote:
> Probably should add a comment explaining that this variable is non-static for
a
> reason.

Done.

http://codereview.chromium.org/155653/diff/1021/1023#newcode41
Line 41: checked_distro = true;
On 2009/07/17 01:33:36, agl wrote:
> Move this down to after the static string is set.

Ok.

http://codereview.chromium.org/155653/diff/1021/1023#newcode49
Line 49: std::string field = "Description:\t";
On 2009/07/17 01:33:36, agl wrote:
> static const

Done.

Expand Messages | Collapse Messages