Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 155647: Adds window position save/restore support for multiple monitors on Mac.... (Closed)

Created:
11 years, 5 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)
Visibility:
Public.

Description

Adds window position save/restore support for multiple monitors on Mac. Fixes a bug where windows would creep up the screen every time you quit/restarted. BUG=http://crbug.com/16176 BUG=http://crbug.com/12854 TEST=Windows should save/restore in the correct location, with either a single monitor or multiple monitors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20911

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -18 lines) Patch
M chrome/browser/cocoa/browser_window_controller.mm View 1 1 chunk +4 lines, -9 lines 0 comments Download
MM chrome/browser/window_sizer_mac.mm View 1 2 1 chunk +55 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pink (ping after 24hrs)
LGTM! http://codereview.chromium.org/155647/diff/1001/6 File chrome/browser/window_sizer_mac.mm (right): http://codereview.chromium.org/155647/diff/1001/6#newcode58 Line 58: // The compiler will complain if we ...
11 years, 5 months ago (2009-07-16 21:19:44 UTC) #1
TVL
11 years, 5 months ago (2009-07-16 21:22:43 UTC) #2
http://codereview.chromium.org/155647/diff/1001/6
File chrome/browser/window_sizer_mac.mm (right):

http://codereview.chromium.org/155647/diff/1001/6#newcode95
Line 95: NSScreen* primary_screen = [[NSScreen screens] objectAtIndex:0];
drive by: why objectAtIndex:0 instead of mainScreen?

Powered by Google App Engine
This is Rietveld 408576698