Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: webkit/glue/window_open_disposition.cc

Issue 155637: Simplify window_open_disposition.cc since we only require conversion from... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/window_open_disposition.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/window_open_disposition.cc
===================================================================
--- webkit/glue/window_open_disposition.cc (revision 20859)
+++ webkit/glue/window_open_disposition.cc (working copy)
@@ -6,38 +6,25 @@
#include "base/logging.h"
-// The macro dance here allows us to only express the mapping once.
-#define MAPPINGS(MAP) \
- MAP(WebNavigationPolicyIgnore, IGNORE_ACTION) \
- MAP(WebNavigationPolicyDownload, SAVE_TO_DISK) \
- MAP(WebNavigationPolicyCurrentTab, CURRENT_TAB) \
- MAP(WebNavigationPolicyNewBackgroundTab, NEW_BACKGROUND_TAB) \
- MAP(WebNavigationPolicyNewForegroundTab, NEW_FOREGROUND_TAB) \
- MAP(WebNavigationPolicyNewWindow, NEW_WINDOW) \
- MAP(WebNavigationPolicyNewPopup, NEW_POPUP)
-
-#define POLICY_TO_DISPOSITION(policy, disposition) \
- case WebKit::policy: return disposition;
-
WindowOpenDisposition NavigationPolicyToDisposition(
WebKit::WebNavigationPolicy policy) {
switch (policy) {
- MAPPINGS(POLICY_TO_DISPOSITION)
+ case WebKit::WebNavigationPolicyIgnore:
+ return IGNORE_ACTION;
+ case WebKit::WebNavigationPolicyDownload:
+ return SAVE_TO_DISK;
+ case WebKit::WebNavigationPolicyCurrentTab:
+ return CURRENT_TAB;
+ case WebKit::WebNavigationPolicyNewBackgroundTab:
+ return NEW_BACKGROUND_TAB;
+ case WebKit::WebNavigationPolicyNewForegroundTab:
+ return NEW_FOREGROUND_TAB;
+ case WebKit::WebNavigationPolicyNewWindow:
+ return NEW_WINDOW;
+ case WebKit::WebNavigationPolicyNewPopup:
+ return NEW_POPUP;
default:
NOTREACHED() << "Unexpected WebNavigationPolicy";
return IGNORE_ACTION;
}
}
-
-#define DISPOSITION_TO_POLICY(policy, disposition) \
- case disposition: return WebKit::policy;
-
-WebKit::WebNavigationPolicy DispositionToNavigationPolicy(
- WindowOpenDisposition disposition) {
- switch (disposition) {
- MAPPINGS(DISPOSITION_TO_POLICY)
- default:
- NOTREACHED() << "Unexpected WindowOpenDisposition";
- return WebKit::WebNavigationPolicyIgnore;
- }
-}
« no previous file with comments | « webkit/glue/window_open_disposition.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698