Issue 155637: Simplify window_open_disposition.cc since we only require conversion from...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155637: Simplify window_open_disposition.cc since we only require conversion from... (Closed)

Created:
11 years, 5 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Simplify window_open_disposition.cc since we only require conversion from WebNavigationPolicy. This is cleanup from the WebWidget patch that you reviewed yesterday. TEST=none BUG=none R=dglazkov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20874

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -30 lines)			Patch
	M	webkit/glue/window_open_disposition.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	webkit/glue/window_open_disposition.cc	View		1 chunk	+14 lines, -27 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages