Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 155607: Set the default minimum font size webkit pref to 10 or 12 ... (Closed)

Created:
11 years, 5 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Set the default minimum font size webkit pref to 12 for Chinese and 10 for ja,ko,ar and th. This will partly resolve [2] one of frequent complains of Chinese users (as long as they use Chinese Chrome). See http://www.google.com/support/forum/p/Chrome/thread?tid=389f306a52817110&hl=en Leave alone other UI language versions alone for now (Firefox has per-script/per-language min font size [1]). Eventually, there need to be per-script which requires the webkit change. [1] http://mxr.mozilla.org/seamonkey/search?string=font.minimum-size (note that Firefox does not set these values by default except for Thai, but offers a UI for a user to adjust). [2] See other issues (feature requests) mentioned in http://crbug.com/16868 BUG=16875 (http://crbug.com/16875) TEST=Open Chrome with '--lang=zh-CN' and go to http://www.popyard.org/ and Chinese characters are larger than before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20987

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/app/resources/locale_settings_ar.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/resources/locale_settings_ja.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/resources/locale_settings_ko.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/resources/locale_settings_th.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/resources/locale_settings_zh-CN.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/resources/locale_settings_zh-TW.xtb View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
11 years, 5 months ago (2009-07-16 00:13:32 UTC) #1
tony
LGTM!
11 years, 5 months ago (2009-07-16 00:15:13 UTC) #2
jungshik at Google
On 2009/07/16 00:15:13, tony wrote: > LGTM! Thank you for the prompt review. After some ...
11 years, 5 months ago (2009-07-17 20:15:16 UTC) #3
tony
11 years, 5 months ago (2009-07-17 20:19:16 UTC) #4
Sounds good to me.

Powered by Google App Engine
This is Rietveld 408576698