Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1556022: Factory Installer. (Closed)

Created:
10 years, 8 months ago by adlr
Modified:
9 years ago
Reviewers:
seano
CC:
chromium-os-reviews_chromium.org, adlr
Visibility:
Public.

Description

Factory Installer. Change build_image to support building a factory install image. Also, a shell script and startup script to run the factory installer. Change software_update startup script to detect if it's a factory install and abort if so. BUG=2378, 2379, 2380 TEST=Tested factory install worked on device. Wrapper script to perform factory install at boot. AU: New arg to install on non-boot device partition. This is used to install in the factory. Also, switch to shflags for argument parsing.

Patch Set 1 #

Patch Set 2 : typo #

Total comments: 6

Patch Set 3 : fixes for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -58 lines) Patch
A src/platform/factory_installer/factory_install.conf View 1 chunk +14 lines, -0 lines 0 comments Download
A src/platform/factory_installer/factory_install.sh View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
M src/platform/memento_softwareupdate/memento_updater.sh View 1 2 10 chunks +75 lines, -47 lines 0 comments Download
M src/platform/memento_softwareupdate/memento_updater_logging.sh View 2 chunks +2 lines, -2 lines 0 comments Download
M src/platform/memento_softwareupdate/ping_omaha.sh View 3 chunks +14 lines, -5 lines 0 comments Download
M src/platform/memento_softwareupdate/software_update.sh View 1 chunk +6 lines, -0 lines 0 comments Download
M src/scripts/build_image View 4 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
adlr
10 years, 8 months ago (2010-04-08 04:10:10 UTC) #1
seano
LGTM++ Could you respond with a quick blurb about how you tested this change? http://codereview.chromium.org/1556022/diff/2001/3002 ...
10 years, 8 months ago (2010-04-08 21:00:11 UTC) #2
adlr
http://codereview.chromium.org/1556022/diff/2001/3002 File src/platform/factory_installer/factory_install.sh (right): http://codereview.chromium.org/1556022/diff/2001/3002#newcode18 src/platform/factory_installer/factory_install.sh:18: DST=/dev/sda On 2010/04/08 21:00:11, seano wrote: > Add comment/TODO ...
10 years, 8 months ago (2010-04-08 22:01:03 UTC) #3
seano
10 years, 8 months ago (2010-04-08 22:51:08 UTC) #4
LGTM...

On 2010/04/08 22:01:03, adlr wrote:
> http://codereview.chromium.org/1556022/diff/2001/3002
> File src/platform/factory_installer/factory_install.sh (right):
> 
> http://codereview.chromium.org/1556022/diff/2001/3002#newcode18
> src/platform/factory_installer/factory_install.sh:18: DST=/dev/sda
> On 2010/04/08 21:00:11, seano wrote:
> > Add comment/TODO that this is probably reliable on x86 only?
> 
> Done.
> 
> http://codereview.chromium.org/1556022/diff/2001/3002#newcode67
> src/platform/factory_installer/factory_install.sh:67: sleep 9999  # sleep
> indefinitely to avoid respawning rather than shutting down
> On 2010/04/08 21:00:11, seano wrote:
> > sleep 1d? :)
> 
> Done.
> 
> http://codereview.chromium.org/1556022/diff/2001/3003
> File src/platform/memento_softwareupdate/memento_updater.sh (right):
> 
> http://codereview.chromium.org/1556022/diff/2001/3003#newcode55
> src/platform/memento_softwareupdate/memento_updater.sh:55:
> SRC=${ROOTDEV%%[0-9]*}
> On 2010/04/08 21:00:11, seano wrote:
> > This could be useful to factor out into common.sh
> 
> I think Antoine is working on a proper replacement for this one-liner that
works
> on ARM. How about we wait for that, then switch to it?

Powered by Google App Engine
This is Rietveld 408576698