Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Unified Diff: tools/gyp/v8.gyp

Issue 155591: Disable dead code stripping for mksnapshot (Closed) Base URL: http://v8.googlecode.com/svn/branches/1.2/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/v8.gyp
===================================================================
--- tools/gyp/v8.gyp (revision 2476)
+++ tools/gyp/v8.gyp (working copy)
@@ -506,6 +506,20 @@
{
'target_name': 'mksnapshot',
'type': 'executable',
+ 'configurations': {
+ 'Release': {
+ 'conditions': [
+ ['OS=="mac"', {
+ 'xcode_settings': {
+ # Dead code stripping is normally enabled for release mode,
+ # but it causes mksnapshot to crash in some situations.
+ # http://code.google.com/p/v8/issues/detail?id=404
+ 'DEAD_CODE_STRIPPING': 'NO',
+ },
+ }],
+ ],
+ },
+ },
'dependencies': [
'v8_nosnapshot',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698