Issue 155546: Merge 20395 - Fix a crash when clicking a popup entry while composing in the ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155546: Merge 20395 - Fix a crash when clicking a popup entry while composing in the ... (Closed)

Created:
11 years, 5 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/193/src/

Visibility:
Public.

Description

Merge 20395 - Fix a crash when clicking a popup entry while composing in the Microsoft IME on XP. We were forcing the IME to close during the process of updating the edit, which in turn caused us to try and handle "changes to the edit", leading to us (wrongly) rerunning autocomplete and blowing away our result set. BUG=13500 TEST=On XP, open a new tab, set the (Microsoft) IME to Hiragana, type 'c', and then click an entry in the popup. The browser should navigate, not crash. Review URL: http://codereview.chromium.org/155330 TBR=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20694

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
	MM	chrome/browser/autocomplete/autocomplete_edit_view_win.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	MM	chrome/browser/autocomplete/autocomplete_edit_view_win.cc	View		4 chunks	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages