Add a variable that forces the release mac builds to use -O1 instead of -Os f...

Add a variable that lets you override the optimization level for release builds (for valgrind -- to avoid inlining, etc.)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20636

[TVL, 2009-07-14 16:55:15]

http://codereview.chromium.org/155501/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/155501/diff/1/2#newcode195
Line 195: ['mac_release_dash_o1', {'GCC_OPTIMIZATION_LEVEL': '1'}],
or would it make more sense to do something like:
['mac_release_optimization', {'GCC_OPTIMIZATION_LEVEL':
'<(mac_release_optimization)'}]

and default it to None so it's unset? (assuming that works)

[Mark Mentovai, 2009-07-14 18:11:50]

http://codereview.chromium.org/155501/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/155501/diff/1/2#newcode195
Line 195: ['mac_release_dash_o1', {'GCC_OPTIMIZATION_LEVEL': '1'}],
On 2009/07/14 16:55:15, TVL wrote:
> or would it make more sense to do something like:
> ['mac_release_optimization', {'GCC_OPTIMIZATION_LEVEL':
> '<(mac_release_optimization)'}]
> 
> and default it to None so it's unset? (assuming that works)

I don't think that'll work, but I do prefer this approach.

We can do
'conditions':[['mac_release_optimization != "UNSET", {'GCC_OPTIMIZATION_LEVEL':
'<(mac_release_optimization'}]]

and provide 'mac_release_optimization%': 'UNSET' as a default.

[TVL, 2009-07-14 18:19:13]

new version up.

[Mark Mentovai, 2009-07-14 18:26:00]

Fix description to be more generic than -O1 and LGTM.