benchmarks/run.html - Issue 155496: Third and hopefully last of thrre CLs to issue a warning when an older...

Side by Side Diff: benchmarks/run.html

Issue 155496: Third and hopefully last of thrre CLs to issue a warning when an older... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"	1 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"

2 "http://www.w3.org/TR/html4/strict.dtd">	2 "http://www.w3.org/TR/html4/strict.dtd">

3 <html lang="en">	3 <html lang="en">

4 <head>	4 <head>

5 <meta http-equiv="Content-Type" content="text/html;charset=iso-8859-1">	5 <meta http-equiv="Content-Type" content="text/html;charset=iso-8859-1">

6 <meta http-equiv="Content-Script-Type" content="text/javascript">	6 <meta http-equiv="Content-Script-Type" content="text/javascript">

7 <meta http-equiv="Content-Style-Type" content="text/css">	7 <meta http-equiv="Content-Style-Type" content="text/css">

8 <title>V8 Benchmark Suite</title>	8 <title>V8 Benchmark Suite</title>

9 <script type="text/javascript" src="base.js"></script>	9 <script type="text/javascript" src="base.js"></script>

10 <script type="text/javascript" src="richards.js"></script>	10 <script type="text/javascript" src="richards.js"></script>

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 }	48 }

49	49

50	50

51 function Run() {	51 function Run() {

52 BenchmarkSuite.RunSuites({ NotifyStep: ShowProgress,	52 BenchmarkSuite.RunSuites({ NotifyStep: ShowProgress,

53 NotifyError: AddError,	53 NotifyError: AddError,

54 NotifyResult: AddResult,	54 NotifyResult: AddResult,

55 NotifyScore: AddScore });	55 NotifyScore: AddScore });

56 }	56 }

57	57

	58 function ShowWarningIfObsolete() {
	Lasse Reichstein 2009/07/14 14:30:46 It might not be worth it to do this check if the b It might not be worth it to do this check if the banchmark is not received over http (i.e., check location.protocol is "http:" or "https:"). Or even if it is read from a location that isn't standard. I.e., something like: if (!/^https?:.*\/v\d+\/run.html/i.test(location.href)) { return; } You can even check that the digits in the href matches BenchmarkSuite.version, or that it comes from the original v8.googlecode.com location.
	59 // If anything goes wrong we will just catch the exception and no

	60 // warning is shown, i.e., no harm is done.

	61 try {

	62 var xmlhttp;

	63 var next_version = parseInt(BenchmarkSuite.version) + 1;

	64 var next_version_url = "../v" + next_version + "/run.html";

	65 if (window.XMLHttpRequest) {
	Lasse Reichstein 2009/07/14 14:30:46 I recommend using if (typeof XMLHttpRequest != "u I recommend using if (typeof XMLHttpRequest != "undefined") { instead. It's dangerous to rely on boolean-conversion of host objects. It's probably not important though (it reputedly works in IE, and that's the most common cause of this kind of problems).
	66 xmlhttp = new window.XMLHttpRequest();
	Lasse Reichstein 2009/07/14 14:30:46 You can drop the "window." in front. You can drop the "window." in front.
	67 } else if (window.ActiveXObject) {
	Lasse Reichstein 2009/07/14 14:30:46 Drop this test completely. If it fails, there is n Drop this test completely. If it fails, there is no case to fall through to, so you might as well just try to create the object and fail if you can't.
	68 xmlhttp = new window.ActiveXObject("Microsoft.XMLHTTP");

	69 }

	70 xmlhttp.open('GET', next_version_url, true);
	Lasse Reichstein 2009/07/14 14:30:46 The third parameter makes the request asynchroneou The third parameter makes the request asynchroneous. That means that the file might be received while the benchmarks are being run, and might affect the results. It would be better to make it synchroneous, so it is done before the benchmarks starts running.
	71 xmlhttp.onreadystatechange = function() {

	72 if (xmlhttp.readyState == 4 && xmlhttp.status == 200) {

	73 document.getElementById('obsolete').style.display="block";

	74 }

	75 };

	76 xmlhttp.send(null);

	77 } catch(e) {

	78 // Ignore exception if check for next version fails.

	79 // Hence no warning is displayed.

	80 }

	81 }

	82

58 function Load() {	83 function Load() {

59 var version = BenchmarkSuite.version;	84 var version = BenchmarkSuite.version;

60 document.getElementById("version").innerHTML = version;	85 document.getElementById("version").innerHTML = version;

	86 ShowWarningIfObsolete();

61 setTimeout(Run, 200);	87 setTimeout(Run, 200);

62 }	88 }

63 </script>	89 </script>

64 </head>	90 </head>

65 <body onload="Load()">	91 <body onload="Load()">

66 <div>	92 <div>

67 <div class="title"><h1>V8 Benchmark Suite - version <span id="version">?</span ></h1></div>	93 <div class="title"><h1>V8 Benchmark Suite - version <span id="version">?</span ></h1></div>

	94 <div class="warning" id="obsolete">

	95 Warning! This is not the latest version of V8 benchmark

	96 suite. Consider running the

	97 <a href="http://v8.googlecode.com/svn/data/benchmarks/current/run.html">

	98 latest version</a>.

	99 </div>

68 <table>	100 <table>

69 <tr>	101 <tr>

70 <td class="contents">	102 <td class="contents">

71 This page contains a suite of pure JavaScript benchmarks that we have	103 This page contains a suite of pure JavaScript benchmarks that we have

72 used to tune V8. The final score is computed as the geometric mean of	104 used to tune V8. The final score is computed as the geometric mean of

73 the individual results to make it independent of the running times of	105 the individual results to make it independent of the running times of

74 the individual benchmarks and of a reference system (score	106 the individual benchmarks and of a reference system (score

75 100). Scores are not comparable across benchmark suite versions and	107 100). Scores are not comparable across benchmark suite versions and

76 higher scores means better performance: <em>Bigger is better!</em>	108 higher scores means better performance: <em>Bigger is better!</em>

77	109

(...skipping 22 matching lines...) Expand all Loading...
100 <div id="status">Starting...</div>	132 <div id="status">Starting...</div>

101 <div id="results">	133 <div id="results">

102 </div>	134 </div>

103 </div>	135 </div>

104 </td></tr></table>	136 </td></tr></table>

105	137

106 </div>	138 </div>

107	139

108 </body>	140 </body>

109 </html>	141 </html>

OLD	NEW

« no previous file with comments | « no previous file | benchmarks/style.css » ('j') | no next file with comments »