Add a presubmit check for accidental checkins of files under a SVN modified d...

presubmit_support.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.3.2'
 
@@ skipping 325 matching lines @@
         integer line number (1-based); and
         the contents of the line as a string.
 
     Note: The cariage return (LF or CR) is stripped off.
     """
     files = self.AffectedSourceFiles(source_file_filter)
     return InputApi._RightHandSideLinesImpl(files)
 
   def ReadFile(self, file, mode='r'):
     """Reads an arbitrary file.
-    
+
     Deny reading anything outside the repository.
     """
     if isinstance(file, AffectedFile):
       file = file.AbsoluteLocalPath()
     if not file.startswith(self.change.RepositoryRoot()):
       raise IOError('Access outside the repository root is denied.')
     return gcl.ReadFile(file, mode)
 
   @staticmethod
   def _RightHandSideLinesImpl(affected_files):
     """Implements RightHandSideLines for InputApi and GclChange."""
     for af in affected_files:
       lines = af.NewContents()
       line_number = 0
       for line in lines:
         line_number += 1
         yield (af, line_number, line)
 
 
 class AffectedFile(object):
   """Representation of a file in a change."""
 
   def __init__(self, path, action, repository_root=''):
     self._path = path
     self._action = action
     self._local_root = repository_root
     self._is_directory = None
     self._properties = {}
-    self.scm = ''
 
   def ServerPath(self):
     """Returns a path string that identifies the file in the SCM system.
 
     Returns the empty string if the file does not exist in SCM.
     """
     return ""
 
   def LocalPath(self):
     """Returns the path of this file on the local disk relative to client root.
@@ skipping 20 matching lines @@
     return self._action
 
   def Property(self, property_name):
     """Returns the specified SCM property of this file, or None if no such
     property.
     """
     return self._properties.get(property_name, None)
 
   def IsTextFile(self):
     """Returns True if the file is a text file and not a binary file.
-    
+
     Deleted files are not text file."""
     raise NotImplementedError()  # Implement when needed
 
   def NewContents(self):
     """Returns an iterator over the lines in the new version of file.
 
     The new version is the file in the user's workspace, i.e. the "right hand
     side".
 
     Contents will be empty if the file is a directory or does not exist.
@@ skipping 24 matching lines @@
     return self.LocalPath()
 
 
 class SvnAffectedFile(AffectedFile):
   """Representation of a file in a change out of a Subversion checkout."""
 
   def __init__(self, *args, **kwargs):
     AffectedFile.__init__(self, *args, **kwargs)
     self._server_path = None
     self._is_text_file = None
-    self.scm = 'svn'
 
   def ServerPath(self):
     if self._server_path is None:
       self._server_path = gclient.CaptureSVNInfo(
           self.AbsoluteLocalPath()).get('URL', '')
     return self._server_path
 
   def IsDirectory(self):
     if self._is_directory is None:
       path = self.AbsoluteLocalPath()
@@ skipping 26 matching lines @@
     return self._is_text_file
 
 
 class GitAffectedFile(AffectedFile):
   """Representation of a file in a change out of a git checkout."""
 
   def __init__(self, *args, **kwargs):
     AffectedFile.__init__(self, *args, **kwargs)
     self._server_path = None
     self._is_text_file = None
-    self.scm = 'git'
 
   def ServerPath(self):
     if self._server_path is None:
       raise NotImplementedException()  # TODO(maruel) Implement.
     return self._server_path
 
   def IsDirectory(self):
     if self._is_directory is None:
       path = self.AbsoluteLocalPath()
       if os.path.exists(path):
@@ skipping 21 matching lines @@
         # raise NotImplementedException()  # TODO(maruel) Implement.
         self._is_text_file = os.path.isfile(self.AbsoluteLocalPath())
     return self._is_text_file
 
 
 class Change(object):
   """Describe a change.
 
   Used directly by the presubmit scripts to query the current change being
   tested.
-  
+
   Instance members:
     tags: Dictionnary of KEY=VALUE pairs found in the change description.
     self.KEY: equivalent to tags['KEY']
   """
 
   _AFFECTED_FILES = AffectedFile
 
   # Matches key/value (or "tag") lines in changelist descriptions.
   _TAG_LINE_RE = re.compile(
       '^\s*(?P<key>[A-Z][A-Z_0-9]*)\s*=\s*(?P<value>.*?)\s*$')
 
   def __init__(self, name, description, local_root, files, issue, patchset):
     if files is None:
       files = []
     self._name = name
     self._full_description = description
     self._local_root = local_root
     self.issue = issue
     self.patchset = patchset
+    self.scm = ''
 
     # From the description text, build up a dictionary of key/value pairs
     # plus the description minus all key/value or "tag" lines.
     self._description_without_tags = []
     self.tags = {}
     for line in self._full_description.splitlines():
       m = self._TAG_LINE_RE.match(line)
       if m:
         self.tags[m.group('key')] = m.group('value')
       else:
@@ skipping 94 matching lines @@
         the contents of the line as a string.
     """
     return InputApi._RightHandSideLinesImpl(
         filter(lambda x: x.IsTextFile(),
                self.AffectedFiles(include_deletes=False)))
 
 
 class SvnChange(Change):
   _AFFECTED_FILES = SvnAffectedFile
 
+  def __init__(self, *args, **kwargs):
+    Change.__init__(self, *args, **kwargs)
+    self.scm = 'svn'
+
+  def GetAllModifiedFiles(self):
+    """Get all modified files."""
+    changelists = gcl.GetModifiedFiles()
+    all_modified_files = []
+    for cl in changelists.values():
+      all_modified_files.extend([f[1] for f in cl])
+    return all_modified_files
+
+  def GetModifiedFiles(self):
+    """Get modified files in the current CL."""
+    changelists = gcl.GetModifiedFiles()
+    return [f[1] for f in changelists[self.Name()]]
+
 
 class GitChange(Change):
   _AFFECTED_FILES = GitAffectedFile
 
+  def __init__(self, *args, **kwargs):
+    Change.__init__(self, *args, **kwargs)
+    self.scm = 'git'
+
 
 def ListRelevantPresubmitFiles(files, root):
   """Finds all presubmit files that apply to a given set of source files.
 
   Args:
     files: An iterable container containing file paths.
     root: Path where to stop searching.
 
   Return:
     List of absolute paths of the existing PRESUBMIT.py scripts.
@@ skipping 226 matching lines @@
                                options.commit,
                                options.verbose,
                                sys.stdout,
                                sys.stdin,
                                options.default_presubmit,
                                options.may_prompt)
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))