Dom Storage (webkit side)

storage/StorageAreaImpl.cpp

Index: storage/StorageAreaImpl.cpp
===================================================================
--- storage/StorageAreaImpl.cpp	(revision 45738)
+++ storage/StorageAreaImpl.cpp	(working copy)
@@ -127,7 +127,7 @@
     ASSERT(!value.isNull());
     blockUntilImportComplete();
     
-    if (frame->page()->settings()->privateBrowsingEnabled()) {
+    if (frame && frame->page()->settings()->privateBrowsingEnabled()) {
         ec = QUOTA_EXCEEDED_ERR;
         return;
     }
@@ -158,7 +158,7 @@
     ASSERT(!m_isShutdown);
     blockUntilImportComplete();
     
-    if (frame->page()->settings()->privateBrowsingEnabled())
+    if (frame && frame->page()->settings()->privateBrowsingEnabled())
         return;
 
     String oldValue;
@@ -179,7 +179,7 @@
     ASSERT(!m_isShutdown);
     blockUntilImportComplete();
     
-    if (frame->page()->settings()->privateBrowsingEnabled())
+    if (frame && frame->page()->settings()->privateBrowsingEnabled())
         return;
     
     m_storageMap = StorageMap::create();
@@ -230,6 +230,10 @@
     // of any given page in the group or mutate the page group itself.
     Vector<RefPtr<Frame> > frames;
 
+    // TODO(jorlow): Make this work!
+    if (!sourceFrame)
+      return;

[michaeln, 2009/07/14 19:02:05]

I realize this is temporary only until you resolve how you're going to deal with
events.

If this test and early return is done at the top of the method body, the the
Vector<> ctor and dtor will not have to run (both smaller and faster code)... so
everything else being equal... would be better to put this test up front.

[jorlow, 2009/07/14 19:12:50]

Sure.  Might as well.

+
     // FIXME: When can this occur?
     Page* page = sourceFrame->page();
     if (!page)

[michaeln, 2009/07/14 19:02:05]

while your here... ditto for this test

[jorlow, 2009/07/14 19:12:50]

k