Dom Storage (webkit side)

storage/StorageAreaImpl.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 109 matching lines @@
     
     return m_storageMap->getItem(key);
 }
 
 void StorageAreaImpl::setItem(const String& key, const String& value, ExceptionCode& ec, Frame* frame)
 {
     ASSERT(!m_isShutdown);
     ASSERT(!value.isNull());
     blockUntilImportComplete();
     
-    if (frame->page()->settings()->privateBrowsingEnabled()) {
+    if (frame && frame->page()->settings()->privateBrowsingEnabled()) {
         ec = QUOTA_EXCEEDED_ERR;
         return;
     }
 
     // FIXME: For LocalStorage where a disk quota will be enforced, here is where we need to do quota checking.
     //        If we decide to enforce a memory quota for SessionStorage, this is where we'd do that, also.
     // if (<over quota>) {
     //     ec = QUOTA_EXCEEDED_ERR;
     //     return;
     // }
@@ skipping 10 matching lines @@
             m_storageAreaSync->scheduleItemForSync(key, value);
         dispatchStorageEvent(key, oldValue, value, frame);
     }
 }
 
 void StorageAreaImpl::removeItem(const String& key, Frame* frame)
 {
     ASSERT(!m_isShutdown);
     blockUntilImportComplete();
     
-    if (frame->page()->settings()->privateBrowsingEnabled())
+    if (frame && frame->page()->settings()->privateBrowsingEnabled())
         return;
 
     String oldValue;
     RefPtr<StorageMap> newMap = m_storageMap->removeItem(key, oldValue);
     if (newMap)
         m_storageMap = newMap.release();
 
     // Only notify the client if an item was actually removed
     if (!oldValue.isNull()) {
         if (m_storageAreaSync)
             m_storageAreaSync->scheduleItemForSync(key, String());
         dispatchStorageEvent(key, oldValue, String(), frame);
     }
 }
 
 void StorageAreaImpl::clear(Frame* frame)
 {
     ASSERT(!m_isShutdown);
     blockUntilImportComplete();
     
-    if (frame->page()->settings()->privateBrowsingEnabled())
+    if (frame && frame->page()->settings()->privateBrowsingEnabled())
         return;
     
     m_storageMap = StorageMap::create();
     
     if (m_storageAreaSync)
         m_storageAreaSync->scheduleClear();
     dispatchStorageEvent(String(), String(), String(), frame);
 }
 
 bool StorageAreaImpl::contains(const String& key) const
@@ skipping 30 matching lines @@
     if (m_storageAreaSync)
         m_storageAreaSync->blockUntilImportComplete();
 }
 
 void StorageAreaImpl::dispatchStorageEvent(const String& key, const String& oldValue, const String& newValue, Frame* sourceFrame)
 {
     // We need to copy all relevant frames from every page to a vector since sending the event to one frame might mutate the frame tree
     // of any given page in the group or mutate the page group itself.
     Vector<RefPtr<Frame> > frames;
 
+    // TODO(jorlow): Make this work!
+    if (!sourceFrame)
+      return;

[michaeln, 2009/07/14 19:02:05]

I realize this is temporary only until you resolve how you're going to deal with
events.

If this test and early return is done at the top of the method body, the the
Vector<> ctor and dtor will not have to run (both smaller and faster code)... so
everything else being equal... would be better to put this test up front.

[jorlow, 2009/07/14 19:12:50]

Sure.  Might as well.

+
     // FIXME: When can this occur?
     Page* page = sourceFrame->page();
     if (!page)

[michaeln, 2009/07/14 19:02:05]

while your here... ditto for this test

[jorlow, 2009/07/14 19:12:50]

k

         return;
 
     if (m_storageType == SessionStorage) {
         // Send events only to our page.
         for (Frame* frame = page->mainFrame(); frame; frame = frame->tree()->traverseNext()) {
             if (frame->document()->securityOrigin()->equal(securityOrigin()))
                 frames.append(frame);
         }
         
         for (unsigned i = 0; i < frames.size(); ++i)
@@ skipping 11 matching lines @@
         
         for (unsigned i = 0; i < frames.size(); ++i)
             frames[i]->document()->dispatchWindowEvent(StorageEvent::create(eventNames().storageEvent, key, oldValue, newValue, sourceFrame->document()->documentURI(), sourceFrame->domWindow(), frames[i]->domWindow()->localStorage()));
     }        
 }
 
 }
 
 #endif // ENABLE(DOM_STORAGE)