Dom Storage (webkit side)

page/DOMWindow.idl

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 142 matching lines @@
         WebKitPoint webkitConvertPointFromNodeToPage(in Node node, in WebKitPoint p);
 
 #if defined(ENABLE_OFFLINE_WEB_APPLICATIONS) && ENABLE_OFFLINE_WEB_APPLICATIONS
         readonly attribute DOMApplicationCache applicationCache;
 #endif    
 #if defined(ENABLE_DATABASE) && ENABLE_DATABASE
         Database openDatabase(in DOMString name, in DOMString version, in DOMString displayName, in unsigned long estimatedSize)
             raises(DOMException);
 #endif
 #if defined(ENABLE_DOM_STORAGE) && ENABLE_DOM_STORAGE
-        readonly attribute Storage sessionStorage;
-        readonly attribute Storage localStorage;
+        readonly attribute [V8Custom] Storage sessionStorage;
+        readonly attribute [V8Custom] Storage localStorage;

[michaeln, 2009/07/14 19:02:05]

Unfortunate we need V8Custom here so the .idl is different for V8 vs JSC? Is
there a v8 binding techinique that would allow us to not embellish this
attributely differently?

Just checking.

[jorlow, 2009/07/14 19:12:50]

If you look, we do this a lot.

The binding is pretty simple.  I don't think this is a big deal, but I think
it's necessary because DOMWindow::localStorage and sessionStorage can return
NULL, but it's improper for us to wrap them in a Storage object...it should
return undefined.

_maybe_ the correct behavior, instead of making this custom (at least once we
get rid of the --enable-*-storage flags) is to change the function that creates
the v8 object...I guess I could try it out and see if the world explodes.

 #endif
 
                  attribute [Replaceable] Console console;
 
         // cross-document messaging
         [DoNotCheckDomainSecurity, Custom] void postMessage(in DOMString message, in [Optional] MessagePort messagePort, in DOMString targetOrigin)
             raises(DOMException);
 
         // Timers
         [Custom] long setTimeout(in TimeoutHandler handler, in long timeout);
@@ skipping 344 matching lines @@
 
 #endif // defined(LANGUAGE_JAVASCRIPT)
 
 #if defined(V8_BINDING) && V8_BINDING
         // window.toString() requires special handling in V8
         [V8DoNotCheckSignature, DoNotCheckDomainSecurity, Custom, DontEnum] DOMString toString();
 #endif // defined(V8_BINDING)
     };
 
 }