Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: media/audio/audio_output.h

Issue 155471: Refactoring to share MockAudioOutputStream implementations across 3 platforms... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output.h
===================================================================
--- media/audio/audio_output.h (revision 20503)
+++ media/audio/audio_output.h (working copy)
@@ -91,9 +91,7 @@
// Starts playing audio and generating AudioSourceCallback::OnMoreData().
// Since implementor of AudioOutputStream may have internal buffers, right
- // after calling this method initial buffers are fetched. User of this
- // object should prepare |AudioOutputStream::GetNumBuffers()| before calling
- // AudioOutputStream::Start().
+ // after calling this method initial buffers are fetched.
//
// The output stream does not take ownership of this callback.
virtual void Start(AudioSourceCallback* callback) = 0;
@@ -114,11 +112,6 @@
// After calling this method, the object should not be used anymore.
virtual void Close() = 0;
- // Gets the number of internal buffers used in this output stream. This
- // method is useful for providing information about how user of this object
- // should prepare initial buffers before calling AudioOutputStream::Start().
- virtual size_t GetNumBuffers() = 0;
-
protected:
virtual ~AudioOutputStream() {}
};
@@ -164,11 +157,6 @@
virtual void MuteAll() = 0;
virtual void UnMuteAll() = 0;
- // For testing purposes only. Returns the internal buffer of the last
- // AUDIO_MOCK AudioOutputStream closed. Returns NULL if none closed yet.
- // The buffer size is the same as passed to AudioOutputStream::Open().
- virtual const void* GetLastMockBuffer() = 0;
-
// Get AudioManager singleton.
// TODO(cpu): Define threading requirements for interacting with AudioManager.
static AudioManager* GetAudioManager();
« no previous file with comments | « chrome/browser/renderer_host/audio_renderer_host_unittest.cc ('k') | media/audio/fake_audio_output_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698