Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 155453: Firefox and Safari both allow calling regular expression objects as... (Closed)

Created:
11 years, 5 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
iposva, Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Firefox and Safari both allow calling regular expression objects as functions (as an alias for calling the exec method). For compatibility make call_regexp the default and remove the flag. Committed: http://code.google.com/p/v8/source/detail?r=2451

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -17 lines) Patch
M src/arm/stub-cache-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/execution.cc View 1 chunk +9 lines, -12 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -3 lines 0 comments Download
A test/mjsunit/regexp-call-as-function.js View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
11 years, 5 months ago (2009-07-13 22:06:01 UTC) #1
Mads Ager (chromium)
Added simple test case to the changelist.
11 years, 5 months ago (2009-07-13 22:31:25 UTC) #2
iposva
11 years, 5 months ago (2009-07-13 23:40:21 UTC) #3
lgtm -ip

Powered by Google App Engine
This is Rietveld 408576698