Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 155446: Adds MSAA information to various (previously uncovered) bits of the UI, inclu... (Closed)

Created:
11 years, 5 months ago by Jonas Klink (Google)
Modified:
9 years, 7 months ago
Reviewers:
jcampan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Adds MSAA information to various (previously uncovered) bits of the UI, including Bookmark and Extensions infobars. This is to moving towards completing the hierarchy for the benefit of full screen reader support. BUG=None. Test=None. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21476

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -29 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 1 7 chunks +52 lines, -2 lines 3 comments Download
M chrome/browser/views/extensions/extension_shelf.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/views/extensions/extension_shelf.cc View 1 5 chunks +27 lines, -14 lines 1 comment Download
M chrome/browser/views/frame/browser_view.cc View 1 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/views/infobars/infobar_container.h View 1 2 chunks +6 lines, -0 lines 2 comments Download
M chrome/browser/views/infobars/infobar_container.cc View 1 1 chunk +19 lines, -0 lines 1 comment Download
M chrome/browser/views/tab_contents/tab_contents_container.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_container.cc View 1 1 chunk +19 lines, -0 lines 1 comment Download
M chrome/browser/views/tabs/tab_strip.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M views/accessibility/accessibility_types.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M views/accessibility/view_accessibility.cc View 1 1 chunk +16 lines, -8 lines 0 comments Download
M views/controls/button/menu_button.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Jonas Klink (Google)
11 years, 5 months ago (2009-07-14 06:57:18 UTC) #1
jcampan
11 years, 5 months ago (2009-07-14 16:44:24 UTC) #2
LGTM with nits

http://codereview.chromium.org/155446/diff/1021/35
File chrome/browser/views/bookmark_bar_view.cc (right):

http://codereview.chromium.org/155446/diff/1021/35#newcode344
Line 344: virtual bool GetAccessibleName(std::wstring* name) {
Nit: DCHECK(name)

http://codereview.chromium.org/155446/diff/1021/35#newcode346
Line 346: (*name).assign(accessible_name_);
Nit: name-> instead of (*name).

http://codereview.chromium.org/155446/diff/1021/35#newcode833
Line 833: (*name).assign(accessible_name_);
Same nits as above: CHECK(name) and name->

http://codereview.chromium.org/155446/diff/1021/28
File chrome/browser/views/extensions/extension_shelf.cc (right):

http://codereview.chromium.org/155446/diff/1021/28#newcode576
Line 576: if (!accessible_name_.empty()) {
Same nit as previously: DCHECK(name), name->assign

http://codereview.chromium.org/155446/diff/1021/26
File chrome/browser/views/infobars/infobar_container.cc (right):

http://codereview.chromium.org/155446/diff/1021/26#newcode76
Line 76: if (!accessible_name_.empty()) {
Same nit as previously mentioned: DCHECK(name), name->assign

http://codereview.chromium.org/155446/diff/1021/27
File chrome/browser/views/infobars/infobar_container.h (right):

http://codereview.chromium.org/155446/diff/1021/27#newcode42
Line 42: protected:
Nit: Add a blank line above "protected:"

http://codereview.chromium.org/155446/diff/1021/27#newcode75
Line 75: // Storage of strings needed for accessibility.
Nit: strings -> the string

http://codereview.chromium.org/155446/diff/1021/30
File chrome/browser/views/tab_contents/tab_contents_container.cc (right):

http://codereview.chromium.org/155446/diff/1021/30#newcode86
Line 86: if (!accessible_name_.empty()) {
Same nit as previously mentioned.

Powered by Google App Engine
This is Rietveld 408576698