Mac-ify the app-based extensions folder name....

Mac-ify the app-based extensions folder name.

BUG=http://crbug.com/16484
TEST=ensure no "extensions" folder is created as a sibling of the app binary


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20525

[TVL, 2009-07-13 16:01:07]

http://codereview.chromium.org/155425/diff/1/2
File app/app_paths.cc (right):

http://codereview.chromium.org/155425/diff/1/2#newcode24
Line 24: cur = cur.Append(FILE_PATH_LITERAL("themes"));
while you're here, does this need fixing?

http://codereview.chromium.org/155425/diff/1/2#newcode47
Line 47: cur = cur.Append(FILE_PATH_LITERAL("PlugIns"));
Do we need plugins for the default plugin?  ie-should it be extensions at this
level instead?  or resources/extensions?

[Avi (use Gerrit), 2009-07-13 16:09:45]

http://codereview.chromium.org/155425/diff/1/2
File app/app_paths.cc (right):

http://codereview.chromium.org/155425/diff/1/2#newcode24
Line 24: cur = cur.Append(FILE_PATH_LITERAL("themes"));
On 2009/07/13 16:01:07, TVL wrote:
> while you're here, does this need fixing?

Those aren't the themes you're thinking of.

http://codereview.chromium.org/155425/diff/1/2#newcode47
Line 47: cur = cur.Append(FILE_PATH_LITERAL("PlugIns"));
On 2009/07/13 16:01:07, TVL wrote:
> Do we need plugins for the default plugin?  ie-should it be extensions at this
> level instead?  or resources/extensions?

:( Right... we already have plugins. I'd still capitalize; that's the Mac Way.

[TVL, 2009-07-13 16:12:57]

lgtm, tx.

[Mark Mentovai, 2009-07-13 16:15:21]

http://codereview.chromium.org/155425/diff/1004/4
File app/app_paths.cc (right):

http://codereview.chromium.org/155425/diff/1004/4#newcode21
Line 21: #if !defined(OS_MACOSX)
Nobody will ever ask for DIR_THEMES on the Mac?

http://codereview.chromium.org/155425/diff/1004/4#newcode47
Line 47: #if defined(OS_MACOSX)
Do we support multiple extensions dirs?

[Avi (use Gerrit), 2009-07-13 16:33:53]

http://codereview.chromium.org/155425/diff/1004/4
File app/app_paths.cc (right):

http://codereview.chromium.org/155425/diff/1004/4#newcode21
Line 21: #if !defined(OS_MACOSX)
On 2009/07/13 16:15:21, Mark Mentovai wrote:
> Nobody will ever ask for DIR_THEMES on the Mac?

They don't now, and if they start to, it'll be pretty obvious what the cause is.

http://codereview.chromium.org/155425/diff/1004/4#newcode47
Line 47: #if defined(OS_MACOSX)
On 2009/07/13 16:15:21, Mark Mentovai wrote:
> Do we support multiple extensions dirs?

This is for extensions that ship with the app; this doesn't apply to extensions
that the users load.