Chromium Code Reviews

Issue 155414: Small cleanup to Utf8::CalculateValue: (Closed)

Created:
11 years, 5 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
Kevin Millikin (Chromium)
CC:
v8-dev
Visibility:
Public.

Description

Small cleanup to Utf8::CalculateValue: - Don't duplicate kMaxXByteChar constants. - Don't compare signed and unsigned integers.

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+4 lines, -9 lines)
M src/unicode.cc View 3 chunks +4 lines, -9 lines 0 comments

Messages

Total messages: 2 (0 generated)
Dean McNamee
Some small cleanup I noticed while stealing this code for Chrome. In Chrome's case it ...
11 years, 5 months ago (2009-07-13 11:12:49 UTC) #1
Kevin Millikin (Chromium)
11 years, 5 months ago (2009-07-13 11:16:33 UTC) #2
LGTM.

Powered by Google App Engine