Issue 155369: Revert "Revert "Add button tinting to the toolbar buttons.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155369: Revert "Revert "Add button tinting to the toolbar buttons."" (Closed)

Created:
11 years, 5 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Revert "Revert "Add button tinting to the toolbar buttons."" This reverts commit r20399 and re-applies the button tinting code. There's a fix for the go button gtk unittest by checking to see if the browser is non-NULL before getting the theme provider. TBR=erg

Patch Set 1 #

Patch Set 2 : rebase #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -38 lines)			Patch
M	chrome/browser/gtk/back_forward_button_gtk.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/custom_button.h	View	4 chunks	+37 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/custom_button.cc	View	2 chunks	+69 lines, -27 lines	0 comments	Download
M	chrome/browser/gtk/go_button_gtk.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/toolbar_star_toggle_gtk.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages