Issue 155366: Linux: don't bother passing the chroot directory fd to the zygote.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155366: Linux: don't bother passing the chroot directory fd to the zygote. (Closed)

Created:
11 years, 5 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Markus (顧孟勤)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: don't bother passing the chroot directory fd to the zygote. Markus pointed out that the cwd was already shared between the chroot helper process and the zygote, therefore we could avoid some complexity in passing the file descriptor so, also, we could then make the directory mode 0000.

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -35 lines)			Patch
	M	chrome/browser/zygote_main_linux.cc	View		1 chunk	+2 lines, -16 lines	0 comments	Download
	M	sandbox/linux/suid/sandbox.cc	View		3 chunks	+3 lines, -19 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages