Issue 155350: Changed hash table to use more of the hash value when probing.

Issue 155350: Changed hash table to use more of the hash value when probing. (Closed)

Created:
11 years, 5 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Changed hash table to use more of the hash value when probing. Committed: http://code.google.com/p/v8/source/detail?r=2486

Patch Set 2 : '' #

Total comments: 4

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -49 lines)			Patch
M	src/arm/ic-arm.cc	View	1	1 chunk	+8 lines, -7 lines	2 comments	Download
M	src/arm/simulator-arm.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	src/ia32/assembler-ia32.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1	1 chunk	+9 lines, -4 lines	0 comments	Download
M	src/objects.h	View	1	3 chunks	+3 lines, -12 lines	0 comments	Download
M	src/objects.cc	View	1	6 chunks	+37 lines, -25 lines	2 comments	Download
M	src/utils.h	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/155350/diff/1004/27 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/155350/diff/1004/27#newcode115 Line 115: __ and_(t1, r3, Operand(t1, ROR, (kShift * ...

11 years, 5 months ago (2009-07-16 12:41:43 UTC) #3

bak

11 years, 5 months ago (2009-07-16 12:52:41 UTC) #4

//Lars

http://codereview.chromium.org/155350/diff/1004/27
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/155350/diff/1004/27#newcode115
Line 115: __ and_(t1, r3, Operand(t1, ROR, (kShift * i) % kBitsPerInt));
On 2009/07/16 12:41:43, Kasper Lund wrote:
> Maybe this needs to be guarded with something like i > 0, becuase I'm not sure
> ROR is legal with a count of zero on ARM.

Fixed, good catch.

http://codereview.chromium.org/155350/diff/1004/21
File src/objects.cc (right):

http://codereview.chromium.org/155350/diff/1004/21#newcode6549
Line 6549: if (nof + (nof>>1) <= capacity) return this;
On 2009/07/16 12:41:43, Kasper Lund wrote:
> Why did you remove the whitespace here?

Too old to remember. I've added the missing spaces.

Expand Messages | Collapse Messages