src/objects-inl.h - Issue 155344: Re-enable ICs for loads and calls that skips a global object during...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 155344: Re-enable ICs for loads and calls that skips a global object during... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

===================================================================

--- src/objects-inl.h (revision 2423)

+++ src/objects-inl.h (working copy)

@@ -2653,7 +2653,7 @@

Object* key,

Object* value,

PropertyDetails details) {

- ASSERT(!key->IsString() || details.index() > 0);

+ ASSERT(!key->IsString() || details.IsDeleted() || details.index() > 0);

antonm 2009/07/10 09:28:43 why this change? just curious.

int index = HashTable<Shape, Key>::EntryToIndex(entry);

WriteBarrierMode mode = FixedArray::GetWriteBarrierMode();

FixedArray::set(index, key, mode);

« src/objects.cc ('K') | « src/objects.cc ('k') | src/stub-cache.h » ('j') | no next file with comments »