Issue 155342: A little bit of bookmark bar cleanup, a little bit of padding improvement....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155342: A little bit of bookmark bar cleanup, a little bit of padding improvement.... (Closed)

Created:
11 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A little bit of bookmark bar cleanup, a little bit of padding improvement. The spacing between the toolbar buttons now matches windows pixel for pixel (tested empirically). The bookmark bar item spacing is now a little better, but we need some hackery to improve it to the state of windows (we need to annex about 5 pixels from the toolbar when the bookmark bar is open). The code for packing bookmark bar buttons is now all in one place. Functional change: There will be no other bookmarks button until the model is loaded. If you care I can fix this, it just doesn't seem like a very important matter since it's unusable anyway when the model isn't loaded.o I also removed a log warning from chrome_dll_main because with this change it started spamming a lot. We're already living with this warning, and have a bug filed for it (they fixed the root problem in newer versions of gtk so I think this bug will just never get resolved), so I don't think this is a big deal. BUG=15870 TEST=things look marginally better, theming still works properly Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20389

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -56 lines)			Patch
M	chrome/app/chrome_dll_main.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/bookmark_bar_gtk.h	View	3 chunks	+4 lines, -8 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_bar_gtk.cc	View	8 chunks	+17 lines, -44 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_utils_gtk.cc	View	4 chunks	+18 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/browser_toolbar_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

do you know why the other bookmarks button has an extra thick border in gtk ...

11 years, 5 months ago (2009-07-10 03:06:39 UTC) #1

Elliot Glaysher

11 years, 5 months ago (2009-07-10 16:45:34 UTC) #2

LGTM

On 2009/07/10 03:06:39, Evan Stade wrote:
> do you know why the other bookmarks button has an extra thick border in gtk
> theme mode (seems true with and without this patch)?

Yeah, it's because the the GtkToolbar is rendering itself and by default renders
a box around its content.

Expand Messages | Collapse Messages